Re: [PATCH for-5.1] Makefile: Remove config-devices.mak on "make clean"

[Peter Maydell]

On Fri, 17 Jul 2020 at 16:30, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> On 7/17/20 5:25 PM, Peter Maydell wrote:
> > The config-devices.mak files are generated by "make", and so they
> > should be deleted by "make clean".
> >
> > (This is different from config-host.mak and config-all-disas.mak,
> > which are created by "configure" and so only deleted by
> > "make distclen".)
>
> typo "distclean"
>
> >
> > If we don't delete these files on "make clean", then the build
> > tree is left in a state where it has the config-devices.mak
> > file but not the config-devices.mak.d file, and make will not
> > realize that it needs to rebuild config-devices.mak if, for
> > instance, hw/sd/Kconfig changes.
> >
> > NB: config-all-devices.mak is also generated by "make", but we
> > already remove it on "make clean".
> >
>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com> ?
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Applied to master with the commit-message fixes so I could merge
the i2c pullreq.

thanks
-- PMM