[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] pc-bios: s390x: Fix bootmap.c zipl component entry data
From: |
Thomas Huth |
Subject: |
Re: [PATCH 1/7] pc-bios: s390x: Fix bootmap.c zipl component entry data handling |
Date: |
Fri, 17 Jul 2020 17:05:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 15/07/2020 11.40, Janosch Frank wrote:
> The two main types of zipl component entries are execute and
> load/data. The last member of the component entry struct therefore
> denotes either a PSW or an address. Let's make this a bit more clear
> by introducing a union and cleaning up the code that uses that struct
> member.
>
> The execute type component entries written by zipl contain short PSWs,
> not addresses. Let's mask them and only pass the address part to
> jump_to_IPL_code(uint64_t address) because it expects an address as
> visible by the name of the argument.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> pc-bios/s390-ccw/bootmap.c | 5 +++--
> pc-bios/s390-ccw/bootmap.h | 7 ++++++-
> 2 files changed, 9 insertions(+), 3 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
[PATCH 3/7] pc-bios: s390x: Remove unneeded dasd-ipl.c reset psw mask changes, Janosch Frank, 2020/07/15
[PATCH 6/7] pc-bios: s390x: Use PSW constants in start.S, Janosch Frank, 2020/07/15