[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] tests: qmp-cmd-test: fix memory leak
From: |
Thomas Huth |
Subject: |
Re: [PATCH v2] tests: qmp-cmd-test: fix memory leak |
Date: |
Thu, 16 Jul 2020 12:47:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 16/07/2020 12.33, Li Qiang wrote:
> Markus Armbruster <armbru@redhat.com> 于2020年7月16日周四 下午5:52写道:
>>
>> Li Qiang <liq3ea@gmail.com> writes:
>>
>>> Markus Armbruster <armbru@redhat.com> 于2020年7月16日周四 下午1:59写道:
>>>>
>>>> Li Qiang <liq3ea@163.com> writes:
>>>>
>>>>> Properly free each test response to avoid memory leak and separate
>>>>> qtest_qmp() calls with spare lines, in a consistent manner.
>>>>>
>>>>> Fixes: 5b88849e7b9("tests/qmp-cmd-test: Add
>>>>> qmp/object-add-failure-modes"
>>>>
>>>> The patch also fixes leaks introduced in 442b09b83d and 9fc719b869,
>>>> actually. At least it should, but the patch appears to be incomplete.
>>
>> 442b09b83d was fine, actually.
>>
>> 9fc719b869 wasn't, and your second patch hunk fixes it. Please add a
>> "Fixes: 9fc719b869' line to the commit message.
>
> Hi Thomas,
>
> Could you do this minor adjustment?
> Add also add Markus's r-b tag.
Sure, I'll add it!
Thomas
Re: [PATCH v2] tests: qmp-cmd-test: fix memory leak, Thomas Huth, 2020/07/16