[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] scripts/tracetool: Use void pointer for vcpu
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 2/4] scripts/tracetool: Use void pointer for vcpu |
Date: |
Thu, 16 Jul 2020 09:57:14 +0100 |
User-agent: |
Mutt/1.14.5 (2020-06-23) |
On Thu, Jul 16, 2020 at 11:17:52AM +0300, Roman Bolshakov wrote:
> dtrace on macOS complains that CPUState * is used for a few probes:
>
> dtrace: failed to compile script trace-dtrace-root.dtrace: line 130: syntax
> error near "CPUState"
>
> A comment in scripts/tracetool/__init__.py mentions that:
>
> We only want to allow standard C types or fixed sized
> integer types. We don't want QEMU specific types
> as we can't assume trace backends can resolve all the
> typedefs
>
> Fixes: 3d211d9f4dbee ("trace: Add 'vcpu' event property to trace guest vCPU")
> Cc: Cameron Esfahani <dirty@apple.com>
> Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
> ---
> scripts/tracetool/vcpu.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 0/4] Add dtrace support on macOS, Roman Bolshakov, 2020/07/16
- [PATCH 1/4] scripts/tracetool: Fix dtrace generation for macOS, Roman Bolshakov, 2020/07/16
- [PATCH 2/4] scripts/tracetool: Use void pointer for vcpu, Roman Bolshakov, 2020/07/16
- Re: [PATCH 2/4] scripts/tracetool: Use void pointer for vcpu,
Daniel P . Berrangé <=
- [PATCH 3/4] build: Don't make object files for dtrace on macOS, Roman Bolshakov, 2020/07/16
- [PATCH 4/4] net/colo: Match is-enabled probe to tracepoint, Roman Bolshakov, 2020/07/16
- Re: [PATCH 0/4] Add dtrace support on macOS, Daniel P . Berrangé, 2020/07/16