[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 6/7] linux-user: fix the errno value in print_syscall_err()
From: |
Laurent Vivier |
Subject: |
[PULL 6/7] linux-user: fix the errno value in print_syscall_err() |
Date: |
Tue, 14 Jul 2020 09:32:58 +0200 |
errno of the target is returned as a negative value by the syscall,
not in the host errno variable.
The emulation of the target syscall can return an error while the
host doesn't set an errno value. Target errnos and host errnos can
also differ in some cases.
Fixes: c84be71f6854 ("linux-user: Extend strace support to enable argument
printing after syscall execution")
Cc: Filip.Bozuta@syrmia.com
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Filip Bozuta <Filip.Bozuta@syrmia.com>
Message-Id: <20200708152435.706070-2-laurent@vivier.eu>
---
linux-user/strace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/strace.c b/linux-user/strace.c
index 39554d903911..7769f53bd5ed 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -731,7 +731,7 @@ print_syscall_err(abi_long ret)
qemu_log(" = ");
if (ret < 0) {
- qemu_log("-1 errno=%d", errno);
+ qemu_log("-1 errno=%d", (int)-ret);
errstr = target_strerror(-ret);
if (errstr) {
qemu_log(" (%s)", errstr);
--
2.26.2
- [PULL 0/7] Linux user for 5.1 patches, Laurent Vivier, 2020/07/14
- [PULL 1/7] linux-user: Use EPROTONOSUPPORT for unimplemented netlink protocols, Laurent Vivier, 2020/07/14
- [PULL 3/7] linux-user: Fix Coverity CID 1430271 / CID 1430272, Laurent Vivier, 2020/07/14
- [PULL 2/7] linux-user: refactor ipc syscall and support of semtimedop syscall, Laurent Vivier, 2020/07/14
- [PULL 5/7] linux-user: add netlink RTM_SETLINK command, Laurent Vivier, 2020/07/14
- [PULL 4/7] linux-user: add new netlink types, Laurent Vivier, 2020/07/14
- [PULL 7/7] linux-user: fix print_syscall_err() when syscall returned value is negative, Laurent Vivier, 2020/07/14
- [PULL 6/7] linux-user: fix the errno value in print_syscall_err(),
Laurent Vivier <=
- Re: [PULL 0/7] Linux user for 5.1 patches, no-reply, 2020/07/14
- Re: [PULL 0/7] Linux user for 5.1 patches, Peter Maydell, 2020/07/14