[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] hw/char/serial: Allow migration of the I/O serial device
From: |
Juan Quintela |
Subject: |
Re: [PATCH 2/2] hw/char/serial: Allow migration of the I/O serial device |
Date: |
Fri, 10 Jul 2020 11:32:22 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> The serial device mapped on the I/O bus hold a migratable
> SerialState. Keep the same version range from SerialState:
>
> 837 const VMStateDescription vmstate_serial = {
> 838 .name = "serial",
> 839 .version_id = 3,
> 840 .minimum_version_id = 2,
>
> Fixes: 10315a7089 ("serial: make SerialIO a sysbus device")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
In the sense that the vmstate stuff is correct.
Reviewed-by: Juan Quintela <quintela@redhat.com>
But as Peter says, it appears that it is better to just drop the whole
serial_io infrastructure if we can switch the mips simulator
implementation to use mm, no?
Later, Juan.