[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 15/16] iotests.py: Adjust HMP kwargs typing
From: |
John Snow |
Subject: |
[PATCH v5 15/16] iotests.py: Adjust HMP kwargs typing |
Date: |
Fri, 10 Jul 2020 01:22:19 -0400 |
mypy wants to ensure there's consistency between the kwargs arguments
types and any unspecified keyword arguments. In this case, conv_keys is
a bool, but the remaining keys are Any type. Mypy (correctly) infers the
**kwargs type to be **Dict[str, str], which is not compatible with
conv_keys: bool.
Because QMP typing is a little fraught right now anyway, re-type kwargs
to Dict[str, Any] which has the benefit of silencing this check right
now.
A future re-design might type these more aggressively, but this will
give us a baseline to work from with minimal disruption.
(Thanks Kevin Wolf for the debugging assist here)
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
---
tests/qemu-iotests/iotests.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 4457786f09..d5cde7c0da 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -553,7 +553,7 @@ def add_incoming(self, addr):
def hmp(self, command_line: str, use_log: bool = False) -> QMPMessage:
cmd = 'human-monitor-command'
- kwargs = {'command-line': command_line}
+ kwargs: Dict[str, Any] = {'command-line': command_line}
if use_log:
return self.qmp_log(cmd, **kwargs)
else:
--
2.21.3
- [PATCH v5 07/16] python/machine.py: Fix monitor address typing, (continued)
- [PATCH v5 07/16] python/machine.py: Fix monitor address typing, John Snow, 2020/07/10
- [PATCH v5 08/16] python/machine.py: reorder __init__, John Snow, 2020/07/10
- [PATCH v5 10/16] python/machine.py: Handle None events in events_wait, John Snow, 2020/07/10
- [PATCH v5 09/16] python/machine.py: Don't modify state in _base_args(), John Snow, 2020/07/10
- [PATCH v5 12/16] python/machine.py: Add _qmp access shim, John Snow, 2020/07/10
- [PATCH v5 11/16] python/machine.py: use qmp.command, John Snow, 2020/07/10
- [PATCH v5 13/16] python/machine.py: fix _popen access, John Snow, 2020/07/10
- [PATCH v5 14/16] python/qemu: make 'args' style arguments immutable, John Snow, 2020/07/10
- [PATCH v5 15/16] iotests.py: Adjust HMP kwargs typing,
John Snow <=
- [PATCH v5 16/16] python/qemu: Add mypy type annotations, John Snow, 2020/07/10
- Re: [PATCH v5 00/16] python: add mypy support to python/qemu, Philippe Mathieu-Daudé, 2020/07/14