[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Remove the CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE switch
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH] Remove the CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE switch |
Date: |
Thu, 9 Jul 2020 09:39:28 +0100 |
User-agent: |
Mutt/1.14.3 (2020-06-14) |
On Thu, Jul 09, 2020 at 07:34:56AM +0200, Thomas Huth wrote:
> GCC supports "#pragma GCC diagnostic" since version 4.6, and
> Clang seems to support it, too, since its early versions 3.x.
> That means that our minimum required compiler versions all support
> this pragma already and we can remove the test from configure and
> all the related #ifdefs in the code.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> configure | 29 -----------------------------
> include/ui/gtk.h | 4 ----
> include/ui/qemu-pixman.h | 4 ----
> scripts/decodetree.py | 12 ++++--------
> ui/gtk.c | 4 ----
> util/coroutine-ucontext.c | 4 ----
> 6 files changed, 4 insertions(+), 53 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|