|
From: | Eric Blake |
Subject: | Re: [PATCH v7 00/47] block: Deal with filters |
Date: | Wed, 8 Jul 2020 15:47:50 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 |
On 7/8/20 12:20 PM, Andrey Shinkevich wrote:
On 25.06.2020 18:21, Max Reitz wrote:v6: https://lists.nongnu.org/archive/html/qemu-devel/2019-08/msg01715.htmlBranch: https://github.com/XanClic/qemu.git child-access-functions-v7Branch: https://git.xanclic.moe/XanClic/qemu.git child-access-functions-v7I cloned the branch from the github and built successfully. Running the iotests reports multiple errors of such a kind: 128: readarray -td '' formatting_line < <(sed -e 's/, fmt=/\x0/') "./common.filter: line 128: readarray: -d: invalid option" introduced with the commit a7399eb iotests: Make _filter_img_create more active
You appear to be staging off an unreleased preliminary tree. a7399eb is not upstream; the upstream commit 'iotests: Make _filter_img_create more active' is commit 57ee95ed, and while it uses readarray, it does not use the problematic -d. In other words, it looks like the problem was caught and fixed in between the original patch creation and the pull request.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |