Re: build error of unused function as MACRO G_DEFINE_AUTOPTR_CLEANUP_FUNC expand

[Philippe Mathieu-Daudé]

On 7/8/20 9:23 PM, Alexander Bulekov wrote:
> Hi Li,
> I usually build the fuzzer with "make i386-softmmu/fuzz", so I must have
> missed the nbd issue... I could not reproduce this locally since:
> 
> alxndr@mozz:qemu(master)$ dpkg -l "*glib2.0-bin*"
> Desired=Unknown/Install/Remove/Purge/Hold
> | Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
> |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
> ||/ Name           Version      Architecture Description
> +++-==============-============-============-=================================
> ii  libglib2.0-bin 2.60.6-2     amd64        Programs for the GLib library
> 
>  The issue described in 9bda600b083 only shows up in versions older than
>  2.57.2... 
> 
> After some digging, in ./configure:
> ...
>   if test "$have_fuzzer" = "yes"; then
>     FUZZ_LDFLAGS=" -fsanitize=address,fuzzer"
>     FUZZ_CFLAGS=" -fsanitize=address,fuzzer"
>     CFLAGS=" -fsanitize=address,fuzzer-no-link"
> 
> Thats probably the issue. Should be
>     CFLAGS="$CFLAGS -fsanitize=address,fuzzer-no-link"

Oops, 3 reviewers missed that...

> 
> I'm also having trouble building, but for a different reason..
> 
> CC=clang-8 CXX=clang++-8  ./configure  --target-list="i386-softmmu" 
> --enable-fuzzing
> ...
>   CC      i386-softmmu/tests/qtest/fuzz/qtest_wrappers.o
> /tmp/qemu/tests/qtest/fuzz/fuzz.c:215:5: error: implicit declaration of 
> function 'rcu_enable_atfork' is invalid in C99 
> [-Werror,-Wimplicit-function-declaration]
>     rcu_enable_atfork();
>     ^
> 45222b9a9016488289a1938a528239c3b83eddb1 is the first bad commit
> commit 45222b9a9016488289a1938a528239c3b83eddb1
> Author: Alexander Bulekov <alxndr@bu.edu>
> Date:   Thu Jun 18 12:05:16 2020 -0400
> 
>     fuzz: fix broken qtest check at rcu_disable_atfork
> 
> Looks like I forgot a header... I'll send fixes for both of these
> issues.
> 
> Thank you
> -Alex