Re: [PATCH 2/4] hw/lm32/milkymist: Comment to remember some IRQs lines are left unwired

[Michael Walle]

Am 2020-07-07 18:30, schrieb Peter Maydell:
> On Sun, 5 Jul 2020 at 22:10, Philippe Mathieu-Daudé <f4bug@amsat.org> 
> wrote:
> > The 'card is readonly' and 'card inserted' IRQs are not wired.
> > Add a comment in case someone know where to wire them.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> >  hw/lm32/milkymist.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c
> > index 469e3c4322..117973c967 100644
> > --- a/hw/lm32/milkymist.c
> > +++ b/hw/lm32/milkymist.c
> > @@ -87,6 +87,7 @@ static DeviceState *milkymist_memcard_create(hwaddr 
> > base)
> >      dev = qdev_new("milkymist-memcard");
> >      sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
> >      sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, base);
> > +    /* FIXME wire 'card is readonly' and 'card inserted' IRQs? */
>
> It's possible that these lines are correctly not wired up
> (ie that the hardware does not provide any kind of indication
> of the r/o or insertion events). The milkymist mmc device is a
> very simple one. AIUI the RTL for the board is on github if
> anybody wants to go check.

That is correct, there are not indications nor are there any
interrupts.

-michael