[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/4] target/avr/cpu: Fix $PC displayed address
From: |
Thomas Huth |
Subject: |
Re: [PATCH v2 2/4] target/avr/cpu: Fix $PC displayed address |
Date: |
Tue, 7 Jul 2020 10:22:04 +0200 |
Am Tue, 7 Jul 2020 09:00:19 +0200
schrieb Philippe Mathieu-Daudé <f4bug@amsat.org>:
> $PC is 16-bit wide. Other registers display addresses on a byte
> granularity.
> To have a coherent ouput, display $PC using byte granularity too.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/avr/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/avr/cpu.c b/target/avr/cpu.c
> index 50fb1c378b..9be464991f 100644
> --- a/target/avr/cpu.c
> +++ b/target/avr/cpu.c
> @@ -151,7 +151,7 @@ static void avr_cpu_dump_state(CPUState *cs, FILE
> *f, int flags) int i;
>
> qemu_fprintf(f, "\n");
> - qemu_fprintf(f, "PC: %06x\n", env->pc_w);
> + qemu_fprintf(f, "PC: %06x\n", env->pc_w * 2);
> qemu_fprintf(f, "SP: %04x\n", env->sp);
> qemu_fprintf(f, "rampD: %02x\n", env->rampD >> 16);
> qemu_fprintf(f, "rampX: %02x\n", env->rampX >> 16);
Reviewed-by: Thomas Huth <huth@tuxfamily.org>