Re: [PATCH v9 4/5] linux-user: Parse NT_GNU_PROPERTY_TYPE_0 notes

[Peter Maydell]

On Wed, 20 May 2020 at 18:28, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> For aarch64, this includes the GNU_PROPERTY_AARCH64_FEATURE_1_BTI bit,
> which indicates that the image should be mapped with guarded pages.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> v9: Only map the startup executable with BTI; anything else must be
>     handled by the interpreter.
> ---
>  linux-user/qemu.h    |   4 ++
>  linux-user/elfload.c | 143 ++++++++++++++++++++++++++++++++-----------
>  2 files changed, 112 insertions(+), 35 deletions(-)

Hi; this patch has some changes which seem to be just code motion
(moving the PT_INTERP handling higher up in the function), some
changes which are coding style fixes (braces), some which are
no-behaviour-change changes (using eppnt->foo instead of phdr[i].foo)
and also the actual BTI related functional change. Could you
split them out, please? I think it would make this easier to review.

thanks
-- PMM