[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 02/18] hw/block/nvme: fix missing endian conversion
From: |
Klaus Jensen |
Subject: |
[PATCH v3 02/18] hw/block/nvme: fix missing endian conversion |
Date: |
Mon, 6 Jul 2020 08:12:47 +0200 |
From: Klaus Jensen <k.jensen@samsung.com>
Fix a missing cpu_to conversion by moving conversion to just before
returning instead.
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Suggested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/block/nvme.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 71b388aa0e20..766cd5b33bb1 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -815,8 +815,8 @@ static uint16_t nvme_get_feature(NvmeCtrl *n, NvmeCmd *cmd,
NvmeRequest *req)
trace_pci_nvme_getfeat_vwcache(result ? "enabled" : "disabled");
break;
case NVME_NUMBER_OF_QUEUES:
- result = cpu_to_le32((n->params.max_ioqpairs - 1) |
- ((n->params.max_ioqpairs - 1) << 16));
+ result = (n->params.max_ioqpairs - 1) |
+ ((n->params.max_ioqpairs - 1) << 16);
trace_pci_nvme_getfeat_numq(result);
break;
case NVME_TIMESTAMP:
@@ -826,7 +826,7 @@ static uint16_t nvme_get_feature(NvmeCtrl *n, NvmeCmd *cmd,
NvmeRequest *req)
return NVME_INVALID_FIELD | NVME_DNR;
}
- req->cqe.result = result;
+ req->cqe.result = cpu_to_le32(result);
return NVME_SUCCESS;
}
--
2.27.0
- [PATCH v3 04/18] hw/block/nvme: add support for the abort command, (continued)
[PATCH v3 02/18] hw/block/nvme: fix missing endian conversion,
Klaus Jensen <=
[PATCH v3 06/18] hw/block/nvme: mark fw slot 1 as read-only, Klaus Jensen, 2020/07/06
[PATCH v3 05/18] hw/block/nvme: add temperature threshold feature, Klaus Jensen, 2020/07/06
[PATCH v3 08/18] hw/block/nvme: add support for the asynchronous event request command, Klaus Jensen, 2020/07/06