Re: [PATCH v2 1/1] disas: mips: Add Loongson 2F disassembler

[Jiaxun Yang]

在 2020/7/3 18:44, Stefan Brankovic 写道:
> Add disassembler for Loongson 2F instruction set.
>
> Testing is done by comparing qemu disassembly output, obtained by
> using -d in_asm command line option, with appropriate objdump output.
>
> This disassembler is written as a generic disassembler that can be
> integrated into other projects. In this case, it is integrated into
> QEMU. One of initial key requirements was that it uses C++ as its
> language.
>
> Signed-off-by: Stefan Brankovic <stefan.brankovic@syrmia.com>

Hi Stefan,

A biref review on the instruction format among some simple test show that
it's working as expected.

Good job!

But I'd agree with Aleksandar's idea, this patch still needs some polishing
on code-style.

Thanks.

> ---
>   MAINTAINERS             |    1 +
>   configure               |    1 +
>   disas/Makefile.objs     |    1 +
>   disas/loongson2f.cpp    | 8154 +++++++++++++++++++++++++++++++++++++++
>   disas/loongson2f.h      | 2562 ++++++++++++
>   include/disas/dis-asm.h |    1 +
>   include/exec/poison.h   |    1 +
>   target/mips/cpu.c       |    4 +
>   8 files changed, 10725 insertions(+)
>   create mode 100644 disas/loongson2f.cpp
>   create mode 100644 disas/loongson2f.h