[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/core/qdev: Increase qdev_realize() kindness
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH] hw/core/qdev: Increase qdev_realize() kindness |
Date: |
Sun, 5 Jul 2020 07:46:02 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 20/06/20 17:38, Philippe Mathieu-Daudé wrote:
> - } else {
> - assert(!DEVICE_GET_CLASS(dev)->bus_type);
> + } else if (DEVICE_GET_CLASS(dev)->bus_type) {
> + error_report("%s: Unexpected bus '%s' for device '%s'",
> + __func__, DEVICE_GET_CLASS(dev)->bus_type,
> + object_get_typename(OBJECT(dev)));
> + abort();
> }
>
Since there is an errp, should we use it and be even kinder?
Paolo