qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] configure / util: Auto-detect the availability of openpty()


From: Thomas Huth
Subject: Re: [PATCH] configure / util: Auto-detect the availability of openpty()
Date: Thu, 2 Jul 2020 19:34:53 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0

On 02/07/2020 18.13, Michele Denber wrote:


On 07/02/20 10:39, Thomas Huth wrote:
Recent versions of Solaris (v11.4) now feature an openpty() function,
too, causing a build failure since we ship our own implementation of
openpty() for Solaris in util/qemu-openpty.c so far. Since there are
now both variants available in the wild, with and without this function,
let's introduce a proper HAVE_OPENPTY define for this to fix the build
failure.

Signed-off-by: Thomas Huth<thuth@redhat.com>
---
  Note: Untested, since I do not have a VM with Solaris. Michele,
  Peter, I'd really appreciate a "Tested-by:" from you here. Thanks!
Sorry, I was off on another project (doing my taxes).  Is this patch missing something?  It looks like there should be more.  The last line is

static void cfmakeraw (struct termios *termios_p) {

with no matching "}".

That's just the context, cut at three lines after the last change. Simply try to apply the patch with "patch -p1 -i ..." or "git am" in a separate git branch if you're using git. It should hopefully apply cleanly.

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]