[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 44/44] hmp: Ignore Error objects where the return value suffic
From: |
Markus Armbruster |
Subject: |
[PATCH v2 44/44] hmp: Ignore Error objects where the return value suffices |
Date: |
Thu, 2 Jul 2020 17:50:00 +0200 |
qdev_print_props() receives and throws away Error objects just to
check for object_property_get_str() and object_property_print()
failure. Unnecessary, both return suitable values, so use those
instead.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
qdev-monitor.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/qdev-monitor.c b/qdev-monitor.c
index 2db38b18af..7ebb97cf0d 100644
--- a/qdev-monitor.c
+++ b/qdev-monitor.c
@@ -695,22 +695,22 @@ static void qdev_print_props(Monitor *mon, DeviceState
*dev, Property *props,
if (!props)
return;
for (; props->name; props++) {
- Error *err = NULL;
char *value;
char *legacy_name = g_strdup_printf("legacy-%s", props->name);
+
if (object_property_get_type(OBJECT(dev), legacy_name, NULL)) {
- value = object_property_get_str(OBJECT(dev), legacy_name, &err);
+ value = object_property_get_str(OBJECT(dev), legacy_name, NULL);
} else {
- value = object_property_print(OBJECT(dev), props->name, true,
&err);
+ value = object_property_print(OBJECT(dev), props->name, true,
+ NULL);
}
g_free(legacy_name);
- if (err) {
- error_free(err);
+ if (!value) {
continue;
}
qdev_printf("%s = %s\n", props->name,
- value && *value ? value : "<null>");
+ *value ? value : "<null>");
g_free(value);
}
}
--
2.26.2
- Re: [PATCH v2 16/44] qapi: Make visitor functions taking Error ** return bool, not void, (continued)
- [PATCH v2 29/44] qom: Use returned bool to check for failure, manual part, Markus Armbruster, 2020/07/02
- [PATCH v2 07/44] qemu-option: Make uses of find_desc_by_name() more similar, Markus Armbruster, 2020/07/02
- [PATCH v2 33/44] error: Avoid unnecessary error_propagate() after error_setg(), Markus Armbruster, 2020/07/02
- [PATCH v2 32/44] qdev: Use returned bool to check for failure, Coccinelle part, Markus Armbruster, 2020/07/02
- [PATCH v2 44/44] hmp: Ignore Error objects where the return value suffices,
Markus Armbruster <=
- [PATCH v2 28/44] qom: Use returned bool to check for failure, Coccinelle part, Markus Armbruster, 2020/07/02
- [PATCH v2 26/44] qom: Put name parameter before value / visitor parameter, Markus Armbruster, 2020/07/02
- Re: [PATCH v2 00/44] Less clumsy error checking, Markus Armbruster, 2020/07/02
- [PATCH v2 39/44] qapi: Smooth visitor error checking in generated code, Markus Armbruster, 2020/07/02
- [PATCH v2 40/44] qapi: Purge error_propagate() from QAPI core, Markus Armbruster, 2020/07/02
- [PATCH v2 35/44] error: Eliminate error_propagate() with Coccinelle, part 2, Markus Armbruster, 2020/07/02