[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/28] test-util-filemonitor: Plug unlikely memory leak
From: |
Markus Armbruster |
Subject: |
[PULL 12/28] test-util-filemonitor: Plug unlikely memory leak |
Date: |
Thu, 2 Jul 2020 13:09:15 +0200 |
test_file_monitor_events() leaks an Error object when
qemu_file_monitor_add_watch() fails, which seems unlikely. Plug it.
Cc: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200630090351.1247703-11-armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---
tests/test-util-filemonitor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/test-util-filemonitor.c b/tests/test-util-filemonitor.c
index 45009c69f4..8f0eff3d03 100644
--- a/tests/test-util-filemonitor.c
+++ b/tests/test-util-filemonitor.c
@@ -495,6 +495,7 @@ test_file_monitor_events(void)
if (*op->watchid < 0) {
g_printerr("Unable to add watch %s",
error_get_pretty(local_err));
+ error_free(local_err);
goto cleanup;
}
if (debug) {
--
2.26.2
- [PULL 00/28] Error reporting patches patches for 2020-07-02, Markus Armbruster, 2020/07/02
- [PULL 01/28] chardev/tcp: Fix error message double free error, Markus Armbruster, 2020/07/02
- [PULL 06/28] tests: Use &error_abort where appropriate, Markus Armbruster, 2020/07/02
- [PULL 12/28] test-util-filemonitor: Plug unlikely memory leak,
Markus Armbruster <=
- [PULL 07/28] tests: Use error_free_or_abort() where appropriate, Markus Armbruster, 2020/07/02
- [PULL 02/28] hw/virtio/virtio-iommu-pci.c: Fix typo in error message, Markus Armbruster, 2020/07/02
- [PULL 15/28] qdev: Drop qbus_set_bus_hotplug_handler() parameter @errp, Markus Armbruster, 2020/07/02
- [PULL 14/28] aspeed: Clean up roundabout error propagation, Markus Armbruster, 2020/07/02
- [PULL 20/28] riscv_hart: Fix riscv_harts_realize() error API violations, Markus Armbruster, 2020/07/02
- [PULL 08/28] usb/dev-mtp: Fix Error double free after inotify failure, Markus Armbruster, 2020/07/02
- [PULL 22/28] x86: Fix x86_cpu_new() error handling, Markus Armbruster, 2020/07/02
- [PULL 10/28] qga: Plug unlikely memory leak in guest-set-memory-blocks, Markus Armbruster, 2020/07/02
- [PULL 11/28] sd/milkymist-memcard: Plug minor memory leak in realize, Markus Armbruster, 2020/07/02
- [PULL 13/28] vnc: Plug minor memory leak in vnc_display_open(), Markus Armbruster, 2020/07/02