Re: [PATCH v3 13/13] vhost-vdpa: introduce vhost-vdpa net client

[Cindy Lu]

Hi Michael, Eric,
This was fix in the latest version, v4
20200701145538.22333-1-lulu@redhat.com/20200701145538.22333-15-lulu@redhat.com/">https://patchew.org/QEMU/20200701145538.22333-1-lulu@redhat.com/20200701145538.22333-15-lulu@redhat.com/

On Wed, Jul 1, 2020 at 11:21 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Wed, Jul 01, 2020 at 09:28:27AM -0500, Eric Blake wrote:
> > On 7/1/20 4:24 AM, Cindy Lu wrote:
> > > This patch set introduces a new net client type: vhost-vdpa.
> > > vhost-vdpa net client will set up a vDPA device which is specified
> > > by a "vhostdev" parameter.
> > >
> > > Signed-off-by: Lingshan Zhu <lingshan.zhu@intel.com>
> > > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> > > Signed-off-by: Cindy Lu <lulu@redhat.com>
> > > Signed-off-by: Jason Wang <jasowang@redhat.com>
> > > ---
> >
> > > +++ b/qapi/net.json
> >
> > >   ##
> > >   # @NetClientDriver:
> > >   #
> > >   # Available netdev drivers.
> > >   #
> > > -# Since: 2.7
> > > +# Since: 5.1
> >
> > This should be:
> >
> > # Since 2.7
> > # @vhost-vdpa since 5.1
> >
> > since the enum itself is still available in older releases, it is only the
> > new member that was introduced in this series.
> >
> > >   ##
> > >   { 'enum': 'NetClientDriver',
> > >     'data': [ 'none', 'nic', 'user', 'tap', 'l2tpv3', 'socket', 'vde',
> > > -            'bridge', 'hubport', 'netmap', 'vhost-user' ] }
> > > +            'bridge', 'hubport', 'netmap', 'vhost-user', 'vhost-vdpa' ] }
> >
>
>
> Thanks! I will fix it up when applying.
> Ack with that fixed?
>
>
> > --
> > Eric Blake, Principal Software Engineer
> > Red Hat, Inc.           +1-919-301-3226
> > Virtualization:  qemu.org | libvirt.org
>