Re: [PATCH v2] tests: disassemble-aml.sh: generate AML in readable format

[no-reply]

Patchew URL: 20200701121349.50523-1-mst@redhat.com/">https://patchew.org/QEMU/20200701121349.50523-1-mst@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v2] tests: disassemble-aml.sh: generate AML in readable format
Type: series
Message-id: 20200701121349.50523-1-mst@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200701121349.50523-1-mst@redhat.com -> 
patchew/20200701121349.50523-1-mst@redhat.com
Switched to a new branch 'test'
ab54232 tests: disassemble-aml.sh: generate AML in readable format

=== OUTPUT BEGIN ===
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16: 
new file mode 100755

WARNING: line over 80 characters
#30: FILE: tests/data/acpi/disassemle-aml.sh:10:
+        echo "Usage: ./tests/data/acpi/disassemle-aml.sh [-o 
<output-directory>]"

ERROR: line over 90 characters
#81: FILE: tests/data/acpi/rebuild-expected-aml.sh:39:
+echo "You can use ${SRC_PATH}/tests/data/acpi/disassemle-aml.sh to disassemble 
them to ASL."

total: 1 errors, 2 warnings, 59 lines checked

Commit ab5423293da2 (tests: disassemble-aml.sh: generate AML in readable 
format) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200701121349.50523-1-mst@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200701121349.50523-1-mst@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com