Re: [PULL 3/6] MAINTAINERS: Add Loongson-3 maintainer and reviewer

[Philippe Mathieu-Daudé]

On 6/29/20 11:56 AM, Aleksandar Markovic wrote:
> понедељак, 29. јун 2020., Philippe Mathieu-Daudé <f4bug@amsat.org
> <mailto:f4bug@amsat.org>> је написао/ла:
> 
>     On 6/27/20 9:51 PM, Aleksandar Markovic wrote:
>     > From: Huacai Chen <zltjiangshi@gmail.com
>     <mailto:zltjiangshi@gmail.com>>
>     >
>     > Add myself as the maintainer for Loongson-3 virtual platforms, and
>     > also add Jiaxun Yang as the reviewer.
>     >
>     > Signed-off-by: Huacai Chen <chenhc@lemote.com
>     <mailto:chenhc@lemote.com>>
>     > Co-developed-by: Jiaxun Yang <jiaxun.yang@flygoat.com
>     <mailto:jiaxun.yang@flygoat.com>>
>     > Reviewed-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com
>     <mailto:aleksandar.qemu.devel@gmail.com>>
>     > Signed-off-by: Aleksandar Markovic
>     <aleksandar.qemu.devel@gmail.com
>     <mailto:aleksandar.qemu.devel@gmail.com>>
>     > Message-Id: <1592995531-32600-5-git-send-email-chenhc@lemote.com
>     <mailto:1592995531-32600-5-git-send-email-chenhc@lemote.com>>
>     > ---
>     >  MAINTAINERS | 7 +++++++
>     >  1 file changed, 7 insertions(+)
>     >
>     > diff --git a/MAINTAINERS b/MAINTAINERS
>     > index 1b40446..fe925ea 100644
>     > --- a/MAINTAINERS
>     > +++ b/MAINTAINERS
>     > @@ -1096,6 +1096,13 @@ F: hw/isa/vt82c686.c
>     >  F: hw/pci-host/bonito.c
>     >  F: include/hw/isa/vt82c686.h
>     > 
>     > +Loongson-3 Virtual Platform
>     > +M: Huacai Chen <chenhc@lemote.com <mailto:chenhc@lemote.com>>
>     > +R: Jiaxun Yang <jiaxun.yang@flygoat.com
>     <mailto:jiaxun.yang@flygoat.com>>
>     > +S: Maintained
>     > +F: hw/mips/loongson3_virt.c
> 
>     This file has not been commited, is this pull request incomplete?
> 
>     > +F: hw/intc/loongson_liointc.c
> 
> 
> This line, in this patch, was my mistake. I did delete the line, but
> forgot to do "git add MAINTAINERS". So, the deletion happened in the
> next patch dealing with MAINTAINERS.
> 
> So, my bad. An honest mistake. I apoligize.
> 
> However, the final outcome of the pull request is 100% as desired, and
> as I informed other in my responses to patches.  No need to do any
> follow ups.
> 
>     How can we test this device?
> 
> 
> Please read the commit message of patch 3/4 of Huacai's recent series v6.

I suppose you are referring to this post:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg716861.html

I prepare the kernel as suggested to add an acceptance test, but then
when testing I get:

$ qemu-system-mips64el -M loongson3-virt,accel=tcg
qemu-system-mips64el: -M loongson3-virt,accel=tcg: unsupported machine type

Are you deliberately merging code into mainstream that is not build
neither used? This might be an acceptable exception, but please
explain why this is an exceptional case, and set a deadline for the
machine to be merged, it has to be in for the next 5.1 release,
else we'll have to revert commit c012e0b1f9 ("hw/intc: Add Loongson
LIOINTC support").

In the past the policy has been to reject contributions from finshed
devices but "unfinished machines". The policy is not strict regarding
that.

>  
> 
>     > +
>     >  Boston
>     >  M: Paul Burton <pburton@wavecomp.com <mailto:pburton@wavecomp.com>>
>     >  R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com
>     <mailto:aleksandar.rikalo@syrmia.com>>
>     >
>