Re: [PATCH] migration: postcopy take proper error return

[Thomas Huth]

On 01/07/2020 11.35, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> This function returns a boolean success and we're returning -1;
> lets just use the 'out' error path.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Fixes: 58b7c17e226 ("Disable mlock around incoming postcopy")
> Buglink: https://bugs.launchpad.net/qemu/+bug/1885720
> ---
>   migration/postcopy-ram.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
> index a36402722b..bef2a3afed 100644
> --- a/migration/postcopy-ram.c
> +++ b/migration/postcopy-ram.c
> @@ -389,7 +389,7 @@ bool postcopy_ram_supported_by_host(MigrationIncomingState 
> *mis)
>        */
>       if (munlockall()) {
>           error_report("%s: munlockall: %s", __func__,  strerror(errno));
> -        return -1;
> +        goto out;
>       }

Sounds like the right thing to do here.

Reviewed-by: Thomas Huth <thuth@redhat.com>