[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/acceptance: Add boot tests for sh4 QEMU advent calenda
|
From: |
Thomas Huth |
|
Subject: |
Re: [PATCH] tests/acceptance: Add boot tests for sh4 QEMU advent calendar image |
|
Date: |
Sat, 30 May 2020 19:25:03 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 30/05/2020 10.54, Aleksandar Markovic wrote:
> 18:44 Pet, 15.05.2020. Thomas Huth <thuth@redhat.com
> <mailto:thuth@redhat.com>> је написао/ла:
>>
>> Now that we can select the second serial console in the acceptance tests
>> (see commit 746f244d9720 "Allow to use other serial consoles than
> default"),
>> we can also test the sh4 image from the QEMU advent calendar 2018.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com <mailto:thuth@redhat.com>>
>> ---
>> I've split my original patch that also added yet another mips64 test...
>> I hope it's easier to review/ack/merge this way this only addresses
> sh4 here.
>>
>
> It makes sense to me, Thomas. If I were you, I would do the same.
>
> But, sorry, do you intend to send mips64 counterpart in future, or it is
> already sent, but I somehow missed it?
Hi Aleksandar,
I was planning to send a separate patch, but then I noticed that there
are already quite a lot of tests for the various flavors of the
mips-malta machine in tests/acceptance/boot_linux_console.py ... so I
currently doubt that the malta advent calendar image will add much value
here?
Thomas