[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 02/58] Revert "hw/prep: realize the PCI root bus as part of th
From: |
Markus Armbruster |
Subject: |
[PATCH v2 02/58] Revert "hw/prep: realize the PCI root bus as part of the prep init" |
Date: |
Fri, 29 May 2020 15:44:27 +0200 |
This reverts commit 685f9a3428f625f580af0123aa95f4838d86cac3.
Realizing a device automatically realizes its buses, in
device_set_realized(). Realizing them in realize methods is
redundant, unless the methods themselves require them to be realized
early. raven_pcihost_realizefn() doesn't. Drop the redundant bus
realization.
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/pci-host/prep.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c
index 1a02e9a670..c821ef889d 100644
--- a/hw/pci-host/prep.c
+++ b/hw/pci-host/prep.c
@@ -268,7 +268,6 @@ static void raven_pcihost_realizefn(DeviceState *d, Error
**errp)
memory_region_add_subregion(address_space_mem, 0xbffffff0, &s->pci_intack);
/* TODO Remove once realize propagates to child devices. */
- object_property_set_bool(OBJECT(&s->pci_bus), true, "realized", errp);
object_property_set_bool(OBJECT(&s->pci_dev), true, "realized", errp);
}
--
2.21.3
- [PATCH v2 00/58] qdev: Rework how we plug into the parent bus, Markus Armbruster, 2020/05/29
- [PATCH v2 01/58] qdev: Rename qbus_realize() to qbus_init(), Markus Armbruster, 2020/05/29
- [PATCH v2 05/58] qdev: Put qdev_new() to use with Coccinelle, Markus Armbruster, 2020/05/29
- [PATCH v2 18/58] isa: New isa_new(), isa_realize_and_unref() etc., Markus Armbruster, 2020/05/29
- [PATCH v2 06/58] qdev: Convert to qbus_realize(), qbus_unrealize(), Markus Armbruster, 2020/05/29
- [PATCH v2 02/58] Revert "hw/prep: realize the PCI root bus as part of the prep init",
Markus Armbruster <=
- [PATCH v2 10/58] qdev: Convert uses of qdev_create() manually, Markus Armbruster, 2020/05/29
- [PATCH v2 08/58] qdev: Convert to qdev_unrealize() manually, Markus Armbruster, 2020/05/29
- [PATCH v2 07/58] qdev: Convert to qdev_unrealize() with Coccinelle, Markus Armbruster, 2020/05/29
- [PATCH v2 03/58] Revert "hw/versatile: realize the PCI root bus as part of the versatile init", Markus Armbruster, 2020/05/29
- [PATCH v2 25/58] ssi: ssi_create_slave_no_init() is now unused, drop, Markus Armbruster, 2020/05/29
- [PATCH v2 14/58] hw/ppc: Eliminate two superfluous QOM casts, Markus Armbruster, 2020/05/29
- [PATCH v2 30/58] qdev: qdev_create(), qdev_try_create() are now unused, drop, Markus Armbruster, 2020/05/29
- [PATCH v2 12/58] qdev: Convert uses of qdev_set_parent_bus() manually, Markus Armbruster, 2020/05/29
- [PATCH v2 19/58] isa: Convert uses of isa_create() with Coccinelle, Markus Armbruster, 2020/05/29