Re: [PATCH 1/2] hmp: Implement qom-get HMP command

[Markus Armbruster]

Markus Armbruster <armbru@redhat.com> writes:

> "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> writes:
>
>> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>>
>> This started off as Andreas Färber's implementation from
>> March 2015, but after feedback from Paolo and Markus it morphed into
>> using the json output which handles structs reasonably.
>>
>> Use with qom-list to find the members of an object.
>>
>> (qemu) qom-get /backend/console[0]/device/vga.rom[0] size
>> 65536
>> (qemu) qom-get /machine smm
>> "auto"
>> (qemu) qom-get /machine rtc-time
>> {
>>     "tm_year": 120,
>>     "tm_sec": 51,
>>     "tm_hour": 9,
>>     "tm_min": 50,
>>     "tm_mon": 4,
>>     "tm_mday": 20
>> }
>> (qemu) qom-get /machine frob
>> Error: Property '.frob' not found
>
>   (qemu) qom-get /machine peripheral
>   "/machine/peripheral"
>
> Not this patch's fault, but WTF?

Because it's not this patch's fault (QMP behaves the same way), we
shouldn't let it block the patch, so
Reviewed-by: Markus Armbruster <armbru@redhat.com>

I just sent

    Subject: QMP qom-get feels useless for child properties
    Date: Fri, 29 May 2020 08:57:11 +0200
    Message-ID: <87lflbns8o.fsf@dusky.pond.sub.org>

[...]