Re: [PATCH 2/3] hw/acpi-build: account for NVDIMM numa nodes in SRAT

[Verma, Vishal L]

On Thu, 2020-05-28 at 12:41 +0200, Igor Mammedov wrote:
> On Thu, 28 May 2020 01:24:42 +0000
> "Verma, Vishal L" <vishal.l.verma@intel.com> wrote:
> > On Thu, 2020-05-21 at 17:16 +0200, Igor Mammedov wrote:
> > 
[..]
> > > 
> > > There is ARM version of build_srat(),
> > > I suggest to put this NVDIMM specific part in helper function within 
> > > hw/acpi/nvdimm.c
> > > and use it from both build_srat() functions.  
> > 
> > Splitting the work out into a helper function in nvdimm.c does make
> > sense, and I've done that. However, looking at the arm version of
> > build_srat and generally in virt-acpi-build.c, I don't see any NVDIMM
> > support, so unless I'm mistaken, it wouldn't make sense to actually call
> > this from the arm version of build_srat.
> 
> perhaps you are lookin into old version on QEMU
> current HEAD has followin snippet:
> 
> virt-acpi-build.c:
>     if (ms->nvdimms_state->is_enabled) {
>         nvdimm_build_acpi(table_offsets, tables_blob, tables->linker,
>                           ms->nvdimms_state, ms->ram_slots);
>     }
>  
Sorry, I jumped the gun on sending v3 and didn't see this email until
after sending it. You're right, I think I was on an older version
before. I've added the nvdimm bit to build_srat here and going to run
through the tests. If everything looks ok I'll send a v4.