Re: [PATCH v2 00/11] Record/replay acceptance tests

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/159057543840.16818.14393433996899521784.stgit@pasha-ThinkPad-X280/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 159057543840.16818.14393433996899521784.stgit@pasha-ThinkPad-X280
Subject: [PATCH v2 00/11] Record/replay acceptance tests
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
ceed53c tests/acceptance: Linux boot test for record/replay
14bf4bc tests/acceptance: refactor boot_linux to allow code reuse
e192fb0 tests/acceptance: record/replay tests with advcal images
0d48aac tests/acceptance: add record/replay test for m68k
1660395 tests/acceptance: add record/replay test for ppc64
881e1cf tests/acceptance: add record/replay test for arm
91c3c1f tests/acceptance: add record/replay test for aarch64
2a236a0 tests/acceptance: add kernel record/replay test for x86_64
bd68b78 tests/acceptance: add base class record/replay kernel tests
69a18b9 tests/acceptance: refactor boot_linux_console test to allow code reuse
f7db49e tests/acceptance: allow console interaction with specific VMs

=== OUTPUT BEGIN ===
1/11 Checking commit f7db49ef403b (tests/acceptance: allow console interaction 
with specific VMs)
2/11 Checking commit 69a18b92426f (tests/acceptance: refactor 
boot_linux_console test to allow code reuse)
3/11 Checking commit bd68b7890ae4 (tests/acceptance: add base class 
record/replay kernel tests)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 64 lines checked

Patch 3/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/11 Checking commit 2a236a011a1b (tests/acceptance: add kernel record/replay 
test for x86_64)
5/11 Checking commit 91c3c1f38968 (tests/acceptance: add record/replay test for 
aarch64)
6/11 Checking commit 881e1cfd51e9 (tests/acceptance: add record/replay test for 
arm)
7/11 Checking commit 1660395b5645 (tests/acceptance: add record/replay test for 
ppc64)
8/11 Checking commit 0d48aac0dbfa (tests/acceptance: add record/replay test for 
m68k)
9/11 Checking commit e192fb06abc8 (tests/acceptance: record/replay tests with 
advcal images)
10/11 Checking commit 14bf4bc65656 (tests/acceptance: refactor boot_linux to 
allow code reuse)
11/11 Checking commit ceed53c0bc8d (tests/acceptance: Linux boot test for 
record/replay)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

ERROR: line over 90 characters
#83: FILE: tests/acceptance/replay_linux.py:41:
+        vm.add_args('-drive', 
'driver=blkreplay,id=disk%s-rr,if=none,image=disk%s' % (id, id))

WARNING: line over 80 characters
#84: FILE: tests/acceptance/replay_linux.py:42:
+        vm.add_args('-device', '%s,drive=disk%s-rr%s' % (device, id, 
bus_string))

WARNING: line over 80 characters
#105: FILE: tests/acceptance/replay_linux.py:63:
+                                                 
logger=self.log.getChild('console'),

ERROR: line over 90 characters
#106: FILE: tests/acceptance/replay_linux.py:64:
+                                                 stop_check=(lambda : not 
vm.is_running()))

WARNING: line over 80 characters
#109: FILE: tests/acceptance/replay_linux.py:67:
+            self.log.info('VM launched, waiting for boot confirmation from 
guest')

WARNING: line over 80 characters
#110: FILE: tests/acceptance/replay_linux.py:68:
+            cloudinit.wait_for_phone_home(('0.0.0.0', self.phone_home_port), 
self.name)

WARNING: line over 80 characters
#113: FILE: tests/acceptance/replay_linux.py:71:
+            self.log.info('VM launched, waiting the recorded execution to be 
replayed')

total: 2 errors, 6 warnings, 104 lines checked

Patch 11/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/159057543840.16818.14393433996899521784.stgit@pasha-ThinkPad-X280/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden