[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/14] hw/mips/malta: Add some logging for bad register offset cas
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 12/14] hw/mips/malta: Add some logging for bad register offset cases |
Date: |
Tue, 26 May 2020 15:32:45 +0200 |
From: Aleksandar Markovic <address@hidden>
Log the cases where a guest attempts read or write using bad
register offset.
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Aleksandar Markovic <address@hidden>
Message-id: <address@hidden>
[PMD: Replaced TARGET_FMT_lx by HWADDR_PRIX]
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/mips/malta.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/hw/mips/malta.c b/hw/mips/malta.c
index e4c4de1b4e..b673a3a248 100644
--- a/hw/mips/malta.c
+++ b/hw/mips/malta.c
@@ -427,10 +427,9 @@ static uint64_t malta_fpga_read(void *opaque, hwaddr addr,
break;
default:
-#if 0
- printf("malta_fpga_read: Bad register offset 0x" TARGET_FMT_lx "\n",
- addr);
-#endif
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "malta_fpga_read: Bad register addr 0x%"HWADDR_PRIX"\n",
+ addr);
break;
}
return val;
@@ -515,10 +514,9 @@ static void malta_fpga_write(void *opaque, hwaddr addr,
break;
default:
-#if 0
- printf("malta_fpga_write: Bad register offset 0x" TARGET_FMT_lx "\n",
- addr);
-#endif
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "malta_fpga_write: Bad register addr 0x%"HWADDR_PRIX"\n",
+ addr);
break;
}
}
--
2.21.3
- [PULL 01/14] MAINTAINERS: Add Huacai Chen as fuloong2e co-maintainer, (continued)
- [PULL 01/14] MAINTAINERS: Add Huacai Chen as fuloong2e co-maintainer, Philippe Mathieu-Daudé, 2020/05/26
- [PULL 02/14] hw/pci-host: Use CONFIG_PCI_BONITO to select the Bonito North Bridge, Philippe Mathieu-Daudé, 2020/05/26
- [PULL 03/14] hw/pci-host/bonito: Fix DPRINTF() format strings, Philippe Mathieu-Daudé, 2020/05/26
- [PULL 04/14] hw/pci-host/bonito: Map peripheral using physical address, Philippe Mathieu-Daudé, 2020/05/26
- [PULL 05/14] hw/pci-host/bonito: Map all the Bonito64 I/O range, Philippe Mathieu-Daudé, 2020/05/26
- [PULL 06/14] hw/pci-host/bonito: Map the different PCI ranges more detailed, Philippe Mathieu-Daudé, 2020/05/26
- [PULL 07/14] hw/pci-host/bonito: Better describe the I/O CS regions, Philippe Mathieu-Daudé, 2020/05/26
- [PULL 08/14] hw/pci-host/bonito: Set the Config register reset value with FIELD_DP32, Philippe Mathieu-Daudé, 2020/05/26
- [PULL 09/14] hw/mips/fuloong2e: Move code and update a comment, Philippe Mathieu-Daudé, 2020/05/26
- [PULL 10/14] hw/mips/fuloong2e: Fix typo in Fuloong machine name, Philippe Mathieu-Daudé, 2020/05/26
- [PULL 12/14] hw/mips/malta: Add some logging for bad register offset cases,
Philippe Mathieu-Daudé <=
- [PULL 14/14] MAINTAINERS: Change Aleksandar Rikalo's email address, Philippe Mathieu-Daudé, 2020/05/26
- [PULL 11/14] hw/mips: Rename malta/mipssim/r4k/jazz files, Philippe Mathieu-Daudé, 2020/05/26
- [PULL 13/14] hw/mips/mips_int: De-duplicate KVM interrupt delivery, Philippe Mathieu-Daudé, 2020/05/26
- Re: [PULL 00/14] mips-hw-next patches for 2020-05-26, Peter Maydell, 2020/05/27