Re: [PATCH 01/19] configure: add --enable-tsan flag + fiber annotations for coroutine-ucontext

[Robert Foley]

On Sat, 23 May 2020 at 12:55, Philippe Mathieu-Daudé <address@hidden> wrote:
>
> Hi Robert,
>
> On 5/22/20 6:07 PM, Robert Foley wrote:
> > From: Lingfeng Yang <address@hidden>
> >
> > We tried running QEMU under tsan in 2016, but tsan's lack of support for
> > longjmp-based fibers was a blocker:
<snip>
> > @@ -6277,6 +6304,14 @@ if test "$have_asan" = "yes"; then
> >             "Without code annotation, the report may be inferior."
> >    fi
> >  fi
> > +if test "$have_tsan" = "yes" ; then
> > +  if test "$have_tsan_iface_fiber" = "yes" ; then
> > +    QEMU_CFLAGS="-fsanitize=thread $QEMU_CFLAGS"
> > +    QEMU_LDFLAGS="-fsanitize=thread $QEMU_LDFLAGS"
> > +  else
> > +    echo "Cannot enable TSAN due to missing fiber annotation interface."
>
> I tried your series and there were no changes anywhere, then I looked at
> how TSan work, started to debug, to finally realize my build was not
> using TSan (clang8). Please use to something such:
>
>      if test "$tsan" = "yes" ; then
>         error_exit "Cannot enable TSAN due to missing fiber" \
>                    "annotation interface."
>      fi

This is a good point.  Will make these changes.

Thanks & Regards,
-Rob