Re: [RFC v3 0/4] QEMU cpus.c refactoring

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [RFC v3 0/4] QEMU cpus.c refactoring
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
0f5db0e cpus: extract out accel-specific code to each accel
1b135cf cpu-timers, icount: new modules
cb5c834 cpu-throttle: new module, extracted from cpus.c
3d5a04d softmmu: move softmmu only files from root

=== OUTPUT BEGIN ===
1/4 Checking commit 3d5a04d99492 (softmmu: move softmmu only files from root)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#112: 
rename from arch_init.c

total: 0 errors, 1 warnings, 77 lines checked

Patch 1/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/4 Checking commit cb5c834770dd (cpu-throttle: new module, extracted from 
cpus.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#110: 
new file mode 100644

total: 0 errors, 1 warnings, 386 lines checked

Patch 2/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/4 Checking commit 1b135cfa40c8 (cpu-timers, icount: new modules)
WARNING: line over 80 characters
#94: FILE: accel/tcg/cpu-exec.c:107:
+            qemu_printf("Warning: The guest is now late by %.1f to %.1f 
seconds\n",

ERROR: line over 90 characters
#265: FILE: hw/core/ptimer.c:137:
+    if (s->enabled == 1 && (delta * period < 10000) && !icount_enabled() && 
!qtest_enabled()) {

ERROR: line over 90 characters
#274: FILE: hw/core/ptimer.c:220:
+            if (!oneshot && (s->delta * period < 10000) && !icount_enabled() 
&& !qtest_enabled()) {

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#384: 
new file mode 100644

total: 2 errors, 2 warnings, 2331 lines checked

Patch 3/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/4 Checking commit 0f5db0e76127 (cpus: extract out accel-specific code to each 
accel)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#86: 
new file mode 100644

total: 0 errors, 1 warnings, 2463 lines checked

Patch 4/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden