[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 15/22] microvm: make virtio irq base runtime configurable
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v3 15/22] microvm: make virtio irq base runtime configurable |
|
Date: |
Mon, 25 May 2020 14:27:13 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 5/25/20 1:49 PM, Gerd Hoffmann wrote:
> Hi,
>
>>> -#define VIRTIO_IRQ_BASE 5
>
>>> + mms->virtio_irq_base = 8;
>>
>> Hmm you made it runtime configurable indeed, but you also changed it from 5
>> to 8. Worth a different patch, or at least mentioning in commit description.
>
> Oops, that wasn't intentional. I'll change it back to 5.
OK. Using 5:
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
[PATCH v3 08/22] acpi: fadt: add hw-reduced sleep register support, Gerd Hoffmann, 2020/05/20
[PATCH v3 19/22] microvm/acpi: use seabios with acpi=on, Gerd Hoffmann, 2020/05/20
[PATCH v3 06/22] acpi: create acpi-common.c and move madt code, Gerd Hoffmann, 2020/05/20
[PATCH v3 05/22] acpi: make build_madt() more generic., Gerd Hoffmann, 2020/05/20
[PATCH v3 12/22] acpi: move acpi_dsdt_add_power_button() to ged, Gerd Hoffmann, 2020/05/20
[PATCH v3 18/22] microvm/acpi: use GSI 16-23 for virtio, Gerd Hoffmann, 2020/05/20