Re: [PATCH] cpus: Fix botched configure_icount() error API violation fix

[Markus Armbruster]

Paolo Bonzini <address@hidden> writes:

> On 08/05/20 12:49, Markus Armbruster wrote:
>> Fixes: abc9bf69a66a11499a801ff545b8fe7adbb3a04c
>> Fixes: Coverity CID 1428754
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  cpus.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/cpus.c b/cpus.c
>> index 5670c96bcf..b9275c672d 100644
>> --- a/cpus.c
>> +++ b/cpus.c
>> @@ -813,7 +813,7 @@ void configure_icount(QemuOpts *opts, Error **errp)
>>          return;
>>      }
>>  
>> -    if (strcmp(option, "auto") != 0) {
>> +    if (option && !strcmp(option, "auto")) {
>>          if (qemu_strtol(option, NULL, 0, &time_shift) < 0
>>              || time_shift < 0 || time_shift > MAX_ICOUNT_SHIFT) {
>>              error_setg(errp, "icount: Invalid shift value");
>> 
>
> Queued, thanks.

This one's wrong, please queue v2 instead.