[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 18/19] target/arm: Fix tsan warning in cpu.c
From: |
Robert Foley |
Subject: |
[PATCH 18/19] target/arm: Fix tsan warning in cpu.c |
Date: |
Fri, 22 May 2020 12:07:54 -0400 |
For example:
WARNING: ThreadSanitizer: data race (pid=11134)
Atomic write of size 4 at 0x7bbc0000e0ac by main thread (mutexes: write M875):
#0 __tsan_atomic32_store <null> (qemu-system-aarch64+0x394d84)
#1 cpu_reset_interrupt hw/core/cpu.c:107:5 (qemu-system-aarch64+0x842f90)
#2 arm_cpu_set_irq target/arm/cpu.c (qemu-system-aarch64+0x615a55)
Previous read of size 4 at 0x7bbc0000e0ac by thread T7:
#0 arm_cpu_has_work target/arm/cpu.c:78:16 (qemu-system-aarch64+0x6178ba)
#1 cpu_has_work include/hw/core/cpu.h:700:12 (qemu-system-aarch64+0x68be2e)
Cc: Peter Maydell <address@hidden>
Cc: Richard Henderson <address@hidden>
Signed-off-by: Robert Foley <address@hidden>
---
target/arm/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index 32bec156f2..cdb90582ee 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -75,7 +75,7 @@ static bool arm_cpu_has_work(CPUState *cs)
ARMCPU *cpu = ARM_CPU(cs);
return (cpu->power_state != PSCI_OFF)
- && cs->interrupt_request &
+ && atomic_read(&cs->interrupt_request) &
(CPU_INTERRUPT_FIQ | CPU_INTERRUPT_HARD
| CPU_INTERRUPT_VFIQ | CPU_INTERRUPT_VIRQ
| CPU_INTERRUPT_EXITTB);
--
2.17.1
- [PATCH 14/19] util/async: Fixed tsan warnings, (continued)
[PATCH 19/19] docs: Added details on TSan to testing.rst, Robert Foley, 2020/05/22
Re: [PATCH 00/19] Add Thread Sanitizer support to QEMU, no-reply, 2020/05/22
Re: [PATCH 00/19] Add Thread Sanitizer support to QEMU, Emilio G. Cota, 2020/05/23