[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/3] virtio: add vhost-user-vsock device
|
From: |
Stefano Garzarella |
|
Subject: |
Re: [PATCH 0/3] virtio: add vhost-user-vsock device |
|
Date: |
Fri, 22 May 2020 12:06:39 +0200 |
On Thu, May 21, 2020 at 03:35:59PM +0100, Stefan Hajnoczi wrote:
> On Fri, May 15, 2020 at 05:21:07PM +0200, Stefano Garzarella wrote:
> > This series add vhost-user-vsock base device and its PCI version
> > (vhost-user-vsock-pci).
> > The vhost-user-vsock device can be used to implement the virtio-vsock
> > device emulation in user-space.
> > An use case might be Kata, where they prefer to emulate devices
> > in user-space.
>
> Looks good.
>
> My main concern is live migration. If it hasn't been tested, please
> remove the live migration code.
>
Migration is not working:
QEMU 5.0.50 monitor - type 'help' for more information
(qemu) migrate -d tcp:0:3333
Error: Migration disabled: vhost-user backend lacks
VHOST_USER_PROTOCOL_F_LOG_SHMFD feature.
Thanks for pointing that out, I'll remove it in v2.
Stefano