Re: [PATCH v1 0/1] target/microblaze: Add GDB XML files

[Edgar E. Iglesias]

On Thu, May 21, 2020 at 09:02:14PM -0700, Joe Komlodi wrote:
> Hi all,
> 
> This adds GDB XML files for Microblaze CPUs.
> For Microblaze, it's split up into core and stack protect XML files.

Hi Joe,

Can you please add a license header to microblaze-core.xml?
I think you wrote this on your own but in case you took it from
GDB (or if they actually are identical) we can keep GDB's
permissive license?

We also need to register the stackprot xml with
gdb_register_coprocessor().

I think you were right about lowering gdb_num_core_regs back to:
    cc->gdb_num_core_regs = 32 + 25;

Things work even if we keep 32 + 27 but I think it's a little
confusing. I've tried a version that uses:

    cc->gdb_num_core_regs = 32 + 25;

And registers stack-prot:
    gdb_register_coprocessor(cs, mb_sp_gdb_get_reg, mb_sp_gdb_set_reg,
                             2, "microblaze-stack-protect.xml", 32 + 25);

That works with GDB from upstream and with Xilinx XSDB.
Vitis 2019.2 microblaze gdb thinks SLR/SHR are 64bit for some
reason and doesn't handle them well with any QEMU version.
We should probably talk to the Vitis folks about changing their
version to match upstream GDB and XSDB.

I'm attaching the diff I used as reference.

Thanks,
Edgar

diff
Description: Text document