[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/8] hw/watchdog: Implement full i.MX watchdog support
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 2/8] hw/watchdog: Implement full i.MX watchdog support |
Date: |
Thu, 21 May 2020 22:04:38 +0100 |
On Sun, 17 May 2020 at 17:21, Guenter Roeck <address@hidden> wrote:
>
> Implement full support for the watchdog in i.MX systems.
> Pretimeout support is optional because the watchdog hardware
> on i.MX31 does not support pretimeouts.
>
> Signed-off-by: Guenter Roeck <address@hidden>
> ---
> +static Property imx2_wdt_properties[] = {
> + DEFINE_PROP_BOOL("pretimeout-support", IMX2WdtState, pretimeout_support,
> + false),
> +};
This Property array is missing the DEFINE_PROP_END_OF_LIST()
terminator entry, which makes QEMU crash on startup on
various host architectures but not x86-64, presumably by
random luck meaning there's some zeros after it there.
I'm going to fix up the version of this commit in my tree.
thanks
-- PMM
- [PATCH v3 0/8] hw/arm: Implement i.MX watchdog support, Guenter Roeck, 2020/05/17
- [PATCH v3 1/8] hw: Move i.MX watchdog driver to hw/watchdog, Guenter Roeck, 2020/05/17
- [PATCH v3 2/8] hw/watchdog: Implement full i.MX watchdog support, Guenter Roeck, 2020/05/17
- Re: [PATCH v3 2/8] hw/watchdog: Implement full i.MX watchdog support,
Peter Maydell <=
- [PATCH v3 3/8] hw/arm/fsl-imx25: Wire up watchdog, Guenter Roeck, 2020/05/17
- [PATCH v3 4/8] hw/arm/fsl-imx31: Wire up watchdog, Guenter Roeck, 2020/05/17
- [PATCH v3 5/8] hw/arm/fsl-imx6: Connect watchdog interrupts, Guenter Roeck, 2020/05/17
- [PATCH v3 6/8] hw/arm/fsl-imx6ul: Connect watchdog interrupts, Guenter Roeck, 2020/05/17
- [PATCH v3 7/8] hw/arm/fsl-imx7: Instantiate various unimplemented devices, Guenter Roeck, 2020/05/17
- [PATCH v3 8/8] hw/arm/fsl-imx7: Connect watchdog interrupts, Guenter Roeck, 2020/05/17
- Re: [PATCH v3 0/8] hw/arm: Implement i.MX watchdog support, Peter Maydell, 2020/05/21