qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 2/8] hw/watchdog: Implement full i.MX watchdog support


From: Peter Maydell
Subject: Re: [PATCH v3 2/8] hw/watchdog: Implement full i.MX watchdog support
Date: Thu, 21 May 2020 22:04:38 +0100

On Sun, 17 May 2020 at 17:21, Guenter Roeck <address@hidden> wrote:
>
> Implement full support for the watchdog in i.MX systems.
> Pretimeout support is optional because the watchdog hardware
> on i.MX31 does not support pretimeouts.
>
> Signed-off-by: Guenter Roeck <address@hidden>
> ---

> +static Property imx2_wdt_properties[] = {
> +    DEFINE_PROP_BOOL("pretimeout-support", IMX2WdtState, pretimeout_support,
> +                     false),
> +};

This Property array is missing the DEFINE_PROP_END_OF_LIST()
terminator entry, which makes QEMU crash on startup on
various host architectures but not x86-64, presumably by
random luck meaning there's some zeros after it there.

I'm going to fix up the version of this commit in my tree.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]