Re: [PATCH 0/7] Latest COLO tree queued patches

[Lukas Straub]

On Thu, 21 May 2020 01:30:48 +0000
"Zhang, Chen" <address@hidden> wrote:

> > -----Original Message-----
> > From: Jason Wang <address@hidden>
> > Sent: Wednesday, May 20, 2020 8:23 PM
> > To: Zhang, Chen <address@hidden>; address@hidden; Lukas
> > Straub <address@hidden>
> > Cc: address@hidden
> > Subject: Re: [PATCH 0/7] Latest COLO tree queued patches
> > 
> > 
> > On 2020/5/20 下午5:07, Zhang, Chen wrote:  
> > > It looks ASan doesn't fully support makecontext/swapcontext functions  
> > and may produce false positives in some cases.  
> > > And Lukas's patch maybe touch it.
> > > What do we need to do?  
> > 
> > 
> > We need first identify if those are false positives. (Which I believe
> > yes, since I don't think this series have effect on the those qtests).
> > 
> > And maybe we can consider to avoid using coroutine .
> >   
> 
> Hi Lukas, Can you double check your patches whether or not are false 
> positives?
> If yes, maybe we can ignore this error. 

Hi,
I ran the qtest's (without ASAN) on my laptop and they pass here, except for 
qos-test which runs into OOM. Also none of the qtest's touch colo-compare code. 
Anyway, I will send another version of my patches to address Philippe's comment 
and to avoid touching softmmu/vl.c.

Regards,
Lukas Straub

> Thanks
> Zhang Chen

pgpGgMQIbL0t4.pgp
Description: OpenPGP digital signature