[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qom/object: simplify type_initialize_interface()
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH] qom/object: simplify type_initialize_interface() |
|
Date: |
Thu, 21 May 2020 16:45:10 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 12/05/20 20:25, Masahiro Yamada wrote:
> iface_impl->class is the same as new_iface. Make it more readable.
>
> Signed-off-by: Masahiro Yamada <address@hidden>
> ---
>
> qom/object.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/qom/object.c b/qom/object.c
> index 9d1a918e42..75c628591d 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -262,8 +262,7 @@ static void type_initialize_interface(TypeImpl *ti,
> TypeImpl *interface_type,
> new_iface->concrete_class = ti->class;
> new_iface->interface_type = interface_type;
>
> - ti->class->interfaces = g_slist_append(ti->class->interfaces,
> - iface_impl->class);
> + ti->class->interfaces = g_slist_append(ti->class->interfaces, new_iface);
> }
>
> static void object_property_free(gpointer data)
>
Queued, thanks.
Paolo