Re: [PATCH v1 01/10] tests/guest-debug: catch hanging guests

[Philippe Mathieu-Daudé]

On 5/13/20 7:51 PM, Alex Bennée wrote:
> If gdb never actually connected with the guest we need to catch that
> and clean-up after ourselves.
>
> Signed-off-by: Alex Bennée <address@hidden>
> Message-Id: <address@hidden>
> ---
>   tests/guest-debug/run-test.py | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/tests/guest-debug/run-test.py b/tests/guest-debug/run-test.py
> index d9af9573b9e..71c55690546 100755
> --- a/tests/guest-debug/run-test.py
> +++ b/tests/guest-debug/run-test.py
> @@ -80,4 +80,10 @@ if __name__ == '__main__':
>           print("GDB crashed? SKIPPING")
>           exit(0)
>   
> +    try:
> +        inferior.wait(2)
> +    except subprocess.TimeoutExpired:
> +        print("GDB never connected? Killed guest")

Maybe "Killing guest"?

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> +        inferior.kill()
> +
>       exit(result)