[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 05/11] ui/gtk: remove unused variable ignore_keys
From: |
Gerd Hoffmann |
Subject: |
[PULL 05/11] ui/gtk: remove unused variable ignore_keys |
Date: |
Wed, 20 May 2020 10:43:10 +0200 |
From: Volker Rümelin <address@hidden>
Since the removal of GTK2 code in commit 89d85cde75 the code
around ignore_keys is unused. See commit 1a01716a30 "gtk: Avoid
accel key leakage into guest on console switch" why it was only
needed for GTK2.
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Volker Rümelin <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/gtk.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index 0e9503a0d1d9..354dd90e1898 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -168,8 +168,6 @@ struct GtkDisplayState {
bool external_pause_update;
- bool ignore_keys;
-
DisplayOptions *opts;
};
@@ -1095,14 +1093,8 @@ static gboolean gd_text_key_down(GtkWidget *widget,
static gboolean gd_key_event(GtkWidget *widget, GdkEventKey *key, void *opaque)
{
VirtualConsole *vc = opaque;
- GtkDisplayState *s = vc->s;
int qcode;
- if (s->ignore_keys) {
- s->ignore_keys = (key->type == GDK_KEY_PRESS);
- return TRUE;
- }
-
#ifdef WIN32
/* on windows, we ought to ignore the reserved key event? */
if (key->hardware_keycode == 0xff)
@@ -1204,7 +1196,6 @@ static void gd_menu_switch_vc(GtkMenuItem *item, void
*opaque)
gtk_notebook_set_current_page(nb, page);
gtk_widget_grab_focus(vc->focus);
}
- s->ignore_keys = false;
}
static void gd_accel_switch_vc(void *opaque)
--
2.18.4
- [PULL 00/11] Ui 20200520 patches, Gerd Hoffmann, 2020/05/20
- [PULL 04/11] ui/gtk: remove unused code, Gerd Hoffmann, 2020/05/20
- [PULL 02/11] ui/gtk: fix handling of AltGr key on Windows, Gerd Hoffmann, 2020/05/20
- [PULL 10/11] ui/gtk: use native keyboard scancodes on Windows, Gerd Hoffmann, 2020/05/20
- [PULL 06/11] ui/sdl2: fix handling of AltGr key on Windows, Gerd Hoffmann, 2020/05/20
- [PULL 11/11] ui: increase min required GTK version to 3.22.0, Gerd Hoffmann, 2020/05/20
- [PULL 07/11] ui/sdl2: start in full screen with grab enabled, Gerd Hoffmann, 2020/05/20
- [PULL 08/11] ui/sdl2-input: use trace-events to debug key events, Gerd Hoffmann, 2020/05/20
- [PULL 03/11] ui/gkt: release all keys on grab-broken-event, Gerd Hoffmann, 2020/05/20
- [PULL 05/11] ui/gtk: remove unused variable ignore_keys,
Gerd Hoffmann <=
- [PULL 09/11] ui/gtk: don't pass on win keys without keyboard grab, Gerd Hoffmann, 2020/05/20
- [PULL 01/11] ui/win32-kbd-hook: handle AltGr in a hook procedure, Gerd Hoffmann, 2020/05/20
- Re: [PULL 00/11] Ui 20200520 patches, Peter Maydell, 2020/05/21