[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/55] qdev: Convert uses of qdev_create() with Coccinelle
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH 08/55] qdev: Convert uses of qdev_create() with Coccinelle |
|
Date: |
Wed, 20 May 2020 08:30:01 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 19/05/20 16:55, Markus Armbruster wrote:
> expression bus, type_name, dev;
> @@
> - dev = qdev_create(bus, type_name);
> + dev = qdev_new(type_name);
> ...
> - qdev_init_nofail(dev);
> + qdev_realize_and_unref(dev, bus, &error_fatal);
>
> The first rule exempts hw/arm/highbank.c, because it matches along two
> control flow paths there, with different @type_name. Covered by the
> next commit's manual conversions.
Slightly better way to express it:
expression bus, type_name, dev;
@@
- dev = qdev_create(bus, type_name);
+ dev = qdev_new(type_name);
... when != dev = qdev_create(...)
- qdev_init_nofail(dev);
+ qdev_realize_and_unref(dev, bus, &error_fatal);
(Just for documentation purposes, the patch is okay of course).
Paolo
- [PATCH 42/55] sysbus: New sysbus_realize(), sysbus_realize_and_unref(), (continued)
- [PATCH 42/55] sysbus: New sysbus_realize(), sysbus_realize_and_unref(), Markus Armbruster, 2020/05/19
- [PATCH 22/55] ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle, Markus Armbruster, 2020/05/19
- [PATCH 27/55] usb: usb_create() is now unused, drop, Markus Armbruster, 2020/05/19
- [PATCH 45/55] sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1, Markus Armbruster, 2020/05/19
- [PATCH 53/55] qdev: Convert bus-less devices to qdev_realize() with Coccinelle, Markus Armbruster, 2020/05/19
- [PATCH 08/55] qdev: Convert uses of qdev_create() with Coccinelle, Markus Armbruster, 2020/05/19
- Re: [PATCH 08/55] qdev: Convert uses of qdev_create() with Coccinelle,
Paolo Bonzini <=
- [PATCH 28/55] usb: Eliminate usb_try_create_simple(), Markus Armbruster, 2020/05/19
- [PATCH 43/55] sysbus: Convert to sysbus_realize() etc. with Coccinelle, Markus Armbruster, 2020/05/19
- [PATCH 55/55] MAINTAINERS: Make section QOM cover hw/core/*bus.c as well, Markus Armbruster, 2020/05/19
- [PATCH 21/55] ssi: ssi_auto_connect_slaves() never does anything, drop, Markus Armbruster, 2020/05/19
- [PATCH 29/55] qdev: qdev_create(), qdev_try_create() are now unused, drop, Markus Armbruster, 2020/05/19
- [PATCH 46/55] sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2, Markus Armbruster, 2020/05/19