Re: [PULL 00/10] softfloat misc cleanups

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [PULL 00/10] softfloat misc cleanups
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
c74e51d softfloat: Return bool from all classification predicates
796da14 softfloat: Inline floatx80 compare specializations
f3197d3 softfloat: Inline float128 compare specializations
c4e06ab softfloat: Inline float64 compare specializations
65adcae softfloat: Inline float32 compare specializations
4afb04e softfloat: Name compare relation enum
5383e5e softfloat: Name rounding mode enum
af9e7fd softfloat: Change tininess_before_rounding to bool
876ddf8 softfloat: Replace flag with bool
802d7a7 softfloat: Use post test for floatN_mul

=== OUTPUT BEGIN ===
1/10 Checking commit 802d7a73a18b (softfloat: Use post test for floatN_mul)
2/10 Checking commit 876ddf8f83ce (softfloat: Replace flag with bool)
3/10 Checking commit af9e7fdfdaed (softfloat: Change tininess_before_rounding 
to bool)
ERROR: space prohibited before that close parenthesis ')'
#68: FILE: fpu/softfloat.c:3877:
+                  || (zExp < 0 )

total: 1 errors, 0 warnings, 143 lines checked

Patch 3/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/10 Checking commit 5383e5ecf1e3 (softfloat: Name rounding mode enum)
5/10 Checking commit 4afb04e42c21 (softfloat: Name compare relation enum)
6/10 Checking commit 65adcae6a290 (softfloat: Inline float32 compare 
specializations)
7/10 Checking commit c4e06abc4c09 (softfloat: Inline float64 compare 
specializations)
8/10 Checking commit f3197d3ad884 (softfloat: Inline float128 compare 
specializations)
9/10 Checking commit 796da149b721 (softfloat: Inline floatx80 compare 
specializations)
10/10 Checking commit c74e51d0ed0d (softfloat: Return bool from all 
classification predicates)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden