[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/24] pnv/phb4: Bury unwanted "pnv-phb4-pec-stack" devices
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH 11/24] pnv/phb4: Bury unwanted "pnv-phb4-pec-stack" devices |
|
Date: |
Tue, 19 May 2020 13:50:27 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Cédric Le Goater <address@hidden> writes:
> On 5/18/20 7:03 AM, Markus Armbruster wrote:
>> The number of stacks is controlled by property "num-stacks".
>> pnv_pec_instance_init() creates the maximum supported number, because
>> the property has not been set then. pnv_pec_realize() realizes only
>> the wanted number. Works, although it can leave unrealized devices
>> hanging around in the QOM composition tree. Affects machine powernv9.
>
> I have used this pattern in many models. Is there a better one ?
The pattern is just fine, we just need to unparent any devices that turn
out to be unwanted.
Of course, when we already know what's wanted at instance_init time,
there's no reason for creating more.
- Re: [PATCH 19/24] riscv: Fix to put "riscv.hart_array" devices on sysbus, (continued)
- [PATCH 13/24] ppc4xx: Drop redundant device realization, Markus Armbruster, 2020/05/18
- [PATCH 11/24] pnv/phb4: Bury unwanted "pnv-phb4-pec-stack" devices, Markus Armbruster, 2020/05/18
- [PATCH 17/24] pnv/psi: Correct the pnv-psi* devices not to be sysbus devices, Markus Armbruster, 2020/05/18
- [PATCH 23/24] sd: Hide the qdev-but-not-quite thing created by sd_init(), Markus Armbruster, 2020/05/18
- [PATCH 10/24] macio: Bury unwanted "macio-gpio" devices, Markus Armbruster, 2020/05/18
- [PATCH 16/24] ppc/pnv: Put "*-pnv-chip" and "pnv-xive" on the main system bus, Markus Armbruster, 2020/05/18