Re: [PATCH v5 01/22] hw/tpm: fix usage of bool in tpm-tis.c

[Aleksandar Markovic]

пон, 18. мај 2020. у 21:42 Aleksandar Markovic
<address@hidden> је написао/ла:
>
> From: Jafar Abdi <address@hidden>
>

This patch was selected by mistake to be included in this series. A ne
version of this series will be sent without this patch.

Sorry about this.

Aleksnadar

> Clean up wrong usage of FALSE and TRUE in places that use "bool" from 
> stdbool.h.
>
> FALSE and TRUE (with capital letters) are the constants defined by glib for
> being used with the "gboolean" type of glib. But some parts of the code also 
> use
> TRUE and FALSE for variables that are declared as "bool" (the type from 
> <stdbool.h>).
>
> Signed-off-by: Jafar Abdi <address@hidden>
> Reviewed-by: Thomas Huth <address@hidden>
> Reviewed-by: Stefan Berger <address@hidden>
> Signed-off-by: Stefan Berger <address@hidden>
> ---
>  hw/tpm/tpm_tis_common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/tpm/tpm_tis_common.c b/hw/tpm/tpm_tis_common.c
> index 9ce64d4836..1af4bce139 100644
> --- a/hw/tpm/tpm_tis_common.c
> +++ b/hw/tpm/tpm_tis_common.c
> @@ -536,7 +536,7 @@ static void tpm_tis_mmio_write(void *opaque, hwaddr addr,
>              while ((TPM_TIS_IS_VALID_LOCTY(s->active_locty) &&
>                      locty > s->active_locty) ||
>                      !TPM_TIS_IS_VALID_LOCTY(s->active_locty)) {
> -                bool higher_seize = FALSE;
> +                bool higher_seize = false;
>
>                  /* already a pending SEIZE ? */
>                  if ((s->loc[locty].access & TPM_TIS_ACCESS_SEIZE)) {
> @@ -546,7 +546,7 @@ static void tpm_tis_mmio_write(void *opaque, hwaddr addr,
>                  /* check for ongoing seize by a higher locality */
>                  for (l = locty + 1; l < TPM_TIS_NUM_LOCALITIES; l++) {
>                      if ((s->loc[l].access & TPM_TIS_ACCESS_SEIZE)) {
> -                        higher_seize = TRUE;
> +                        higher_seize = true;
>                          break;
>                      }
>                  }
> --
> 2.20.1
>