Re: [PATCH v4 9/9] iotests: Add test 291 to for qemu-img bitmap coverage

[Vladimir Sementsov-Ogievskiy]

13.05.2020 04:16, Eric Blake wrote:
> Add a new test covering the 'qemu-img bitmap' subcommand, as well as
> 'qemu-img convert --bitmaps', both added in recent patches.
>
> Signed-off-by: Eric Blake <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>


Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>

> ---
>   tests/qemu-iotests/291     | 112 +++++++++++++++++++++++++++++++++++++
>   tests/qemu-iotests/291.out |  78 ++++++++++++++++++++++++++
>   tests/qemu-iotests/group   |   1 +
>   3 files changed, 191 insertions(+)
>   create mode 100755 tests/qemu-iotests/291
>   create mode 100644 tests/qemu-iotests/291.out
>
> diff --git a/tests/qemu-iotests/291 b/tests/qemu-iotests/291
> new file mode 100755
> index 000000000000..3ca83b9cd1f7
> --- /dev/null
> +++ b/tests/qemu-iotests/291
> @@ -0,0 +1,112 @@
> +#!/usr/bin/env bash
> +#
> +# Test qemu-img bitmap handling

[..]

> +TEST_IMG="$TEST_IMG.base" _make_test_img 10M
> +$QEMU_IMG bitmap --add -f $IMGFMT "$TEST_IMG.base" b0
> +$QEMU_IO -c 'w 3M 1M' -f $IMGFMT "$TEST_IMG.base" | _filter_qemu_io

Actually '-f $IMGFMT' option is already inside $QEMU_IO. Still it's a kind of 
standard for iotests to duplicate -f option, so I don't care. I hope one day 
we'll restrict it in qemu-io interface :)

--
Best regards,
Vladimir