|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH 0/2] exec/memory: Enforce checking MemTxResult values |
Date: | Mon, 18 May 2020 13:20:19 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 5/18/20 11:46 AM, Peter Maydell wrote:
On Sun, 17 May 2020 at 17:48, Philippe Mathieu-Daudé <address@hidden> wrote:Various places ignore the MemTxResult indicator of transaction failed. Some cases might be justified (DMA?) while other are probably bugs. To avoid ignoring transaction errors, suggestion is to mark functions returning MemTxResult with warn_unused_result attribute.Not necessarily a bad idea, but don't we have an awful lot of places that ignore the result that we'd need to fix first?
Yes, there are various places to fix. I wanted to have a preview first, and not start working on this if it is later rejected. Most of the cases are hardware specific and require studying each hardware behavior.
[Prev in Thread] | Current Thread | [Next in Thread] |