[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 17/17] hw/mips: Convert Malta "ifdef 0"-ed code to comments
From: |
Aleksandar Markovic |
Subject: |
[PATCH v2 17/17] hw/mips: Convert Malta "ifdef 0"-ed code to comments |
Date: |
Thu, 14 May 2020 21:20:47 +0200 |
The checkpatch complain about "#ifdef 0". Convert corresponding
dead code to comments. In future, these cases could be converted
to some no-nonsense logging/tracing.
Signed-off-by: Aleksandar Markovic <address@hidden>
CC: Philippe Mathieu-Daudé <address@hidden>
---
hw/mips/mips_malta.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
index e4c4de1b4e..f91fa34b06 100644
--- a/hw/mips/mips_malta.c
+++ b/hw/mips/mips_malta.c
@@ -427,10 +427,12 @@ static uint64_t malta_fpga_read(void *opaque, hwaddr addr,
break;
default:
-#if 0
- printf("malta_fpga_read: Bad register offset 0x" TARGET_FMT_lx "\n",
- addr);
-#endif
+/*
+ * Possible logging:
+ *
+ * printf("malta_fpga_read: Bad register offset 0x" TARGET_FMT_lx "\n",
+ * addr);
+ */
break;
}
return val;
@@ -515,10 +517,12 @@ static void malta_fpga_write(void *opaque, hwaddr addr,
break;
default:
-#if 0
- printf("malta_fpga_write: Bad register offset 0x" TARGET_FMT_lx "\n",
- addr);
-#endif
+/*
+ * Possible logging:
+ *
+ * printf("malta_fpga_write: Bad register offset 0x" TARGET_FMT_lx "\n",
+ * addr);
+ */
break;
}
}
--
2.20.1
- [PATCH v2 04/17] target/mips: fpu: Demacro DIV.<D|S|PS>, (continued)
- [PATCH v2 04/17] target/mips: fpu: Demacro DIV.<D|S|PS>, Aleksandar Markovic, 2020/05/14
- [PATCH v2 05/17] target/mips: fpu: Remove now unused macro FLOAT_BINOP, Aleksandar Markovic, 2020/05/14
- [PATCH v2 07/17] target/mips: fpu: Demacro MSUB.<D|S|PS>, Aleksandar Markovic, 2020/05/14
- [PATCH v2 09/17] target/mips: fpu: Demacro NMSUB.<D|S|PS>, Aleksandar Markovic, 2020/05/14
- [PATCH v2 06/17] target/mips: fpu: Demacro MADD.<D|S|PS>, Aleksandar Markovic, 2020/05/14
- [PATCH v2 10/17] target/mips: fpu: Remove now unused UNFUSED_FMA and FLOAT_FMA macros, Aleksandar Markovic, 2020/05/14
- [PATCH v2 15/17] target/mips: fpu: Name better paired-single variables, Aleksandar Markovic, 2020/05/14
- [PATCH v2 11/17] target/mips: fpu: Demacro CLASS.<D|S>, Aleksandar Markovic, 2020/05/14
- [PATCH v2 13/17] target/mips: fpu: Demacro RINT.<D|S>, Aleksandar Markovic, 2020/05/14
- [PATCH v2 16/17] target/mips: fpu: Refactor conversion from ieee to mips exception flags, Aleksandar Markovic, 2020/05/14
- [PATCH v2 17/17] hw/mips: Convert Malta "ifdef 0"-ed code to comments,
Aleksandar Markovic <=
[PATCH v2 12/17] target/mips: fpu: Remove now unused FLOAT_CLASS macro, Aleksandar Markovic, 2020/05/14
[PATCH v2 08/17] target/mips: fpu: Demacro NMADD.<D|S|PS>, Aleksandar Markovic, 2020/05/14
[PATCH v2 14/17] target/mips: fpu: Remove now unused FLOAT_RINT macro, Aleksandar Markovic, 2020/05/14