[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 5/6] tests/fuzz: Extract pciconfig_fuzz_qos() method
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 5/6] tests/fuzz: Extract pciconfig_fuzz_qos() method |
Date: |
Thu, 14 May 2020 16:34:32 +0200 |
Extract the generic pciconfig_fuzz_qos() method from
i440fx_fuzz_qos(). This will help to write tests not
specific to the i440FX controller.
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
tests/qtest/fuzz/i440fx_fuzz.c | 20 ++++++++++++++------
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/tests/qtest/fuzz/i440fx_fuzz.c b/tests/qtest/fuzz/i440fx_fuzz.c
index c197b026db..558fa17c93 100644
--- a/tests/qtest/fuzz/i440fx_fuzz.c
+++ b/tests/qtest/fuzz/i440fx_fuzz.c
@@ -84,7 +84,7 @@ static void i440fx_fuzz_qtest(QTestState *s,
flush_events(s);
}
-static void i440fx_fuzz_qos(QTestState *s,
+static void pciconfig_fuzz_qos(QTestState *s, QPCIBus *bus,
const unsigned char *Data, size_t Size) {
/*
* Same as i440fx_fuzz_qtest, but using QOS. devfn is incorporated into the
@@ -97,11 +97,6 @@ static void i440fx_fuzz_qos(QTestState *s,
uint32_t value;
} a;
- static QPCIBus *bus;
- if (!bus) {
- bus = qpci_new_pc(s, fuzz_qos_alloc);
- }
-
while (Size >= sizeof(a)) {
memcpy(&a, Data, sizeof(a));
switch (a.opcode % ACTION_MAX) {
@@ -130,6 +125,19 @@ static void i440fx_fuzz_qos(QTestState *s,
flush_events(s);
}
+static void i440fx_fuzz_qos(QTestState *s,
+ const unsigned char *Data,
+ size_t Size)
+{
+ static QPCIBus *bus;
+
+ if (!bus) {
+ bus = qpci_new_pc(s, fuzz_qos_alloc);
+ }
+
+ pciconfig_fuzz_qos(s, bus, Data, Size);
+}
+
static void i440fx_fuzz_qos_fork(QTestState *s,
const unsigned char *Data, size_t Size) {
if (fork() == 0) {
--
2.21.3
- [PATCH 0/6] tests/fuzz: Review notes, Philippe Mathieu-Daudé, 2020/05/14
- [PATCH 1/6] tests/fuzz/Makefile: Do not link code using unavailable devices, Philippe Mathieu-Daudé, 2020/05/14
- [PATCH 2/6] Makefile: List fuzz targets in 'make help', Philippe Mathieu-Daudé, 2020/05/14
- [PATCH 3/6] tests/fuzz: Add missing space in test description, Philippe Mathieu-Daudé, 2020/05/14
- [PATCH 4/6] tests/fuzz: Remove unuseful/unused typedefs, Philippe Mathieu-Daudé, 2020/05/14
- [PATCH 5/6] tests/fuzz: Extract pciconfig_fuzz_qos() method,
Philippe Mathieu-Daudé <=
- [PATCH 6/6] tests/fuzz: Extract ioport_fuzz_qtest() method, Philippe Mathieu-Daudé, 2020/05/14
- Re: [PATCH 0/6] tests/fuzz: Review notes, Stefan Hajnoczi, 2020/05/15
- Re: [PATCH 0/6] tests/fuzz: Review notes, Alexander Bulekov, 2020/05/15