Re: [PATCH v3 1/3] qemu-sockets: add abstract UNIX domain socket support

[Daniel P . Berrangé]

On Sun, May 10, 2020 at 02:14:20PM +0800, xiaoqiang zhao wrote:
> unix_listen/connect_saddr now support abstract address types
> 
> two aditional BOOL switches are introduced:
> tight: whether to set @addrlen to the minimal string length,
>        or the maximum sun_path length. default is TRUE
> abstract: whether we use abstract address. default is FALSE
> 
> cli example:
> -monitor unix:/tmp/unix.socket,abstract,tight=off
> OR
> -chardev socket,path=/tmp/unix.socket,id=unix1,abstract,tight=on
> 
> Signed-off-by: xiaoqiang zhao <address@hidden>
> ---
>  chardev/char-socket.c |  4 ++++
>  chardev/char.c        |  7 +++++++
>  qapi/sockets.json     |  9 ++++++++-
>  util/qemu-sockets.c   | 39 ++++++++++++++++++++++++++++++++-------
>  4 files changed, 51 insertions(+), 8 deletions(-)

With the changes Eric suggests, then

Reviewed-by: Daniel P. Berrangé <address@hidden>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|